-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Dispatch patch tag workflow instead of running directly #139
ENH Dispatch patch tag workflow instead of running directly #139
Conversation
b078c0f
to
e2e1368
Compare
Note that https://github.com/GuySartorelli/issue-template-playground/actions/runs/10153987547/job/28078370071 shows the workflow fails when the |
e2e1368
to
cbaefcc
Compare
permissions: | ||
pull-requests: read | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- With no permissions we get told we need
pull-requests: read
. - After adding that, we get told we need
contents:read
- With both permissions we have no permissions errors.
Ignore the fact that CI there is still red - that's just 'cause there's nothing for generate-matrix to output for that repo, and CI doesn't like having no matrix when it's told there will be one.
I also tested these permissions in a repo that actually does get a generated matrix and it works as expected, red job not-withstanding
c114970
to
fb79593
Compare
52a34d0
to
95cf4d1
Compare
95cf4d1
to
250867c
Compare
Rebased so CI passes in my repo (needed the chromedriver fix) |
Dispatches the new workflow added in silverstripe/module-standardiser#66 instead of running patch tagging directly.
This removes the need for
content:write
permissions inci.yml
Issue